airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] sprzedwojski opened a new pull request #4192: [AIRFLOW-3345] Add Google Cloud Storage (GCS) operators for ACL
Date Thu, 15 Nov 2018 09:01:24 GMT
sprzedwojski opened a new pull request #4192: [AIRFLOW-3345] Add Google Cloud Storage (GCS)
operators for ACL
   ### Jira
   - [x] My PR addresses the following [Airflow Jira](
issues and references them in the PR title.
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Add 2 operators for adding ACL entries to GCS buckets and objects:
   - GoogleCloudStorageBucketCreateAclEntryOperator
   - GoogleCloudStorageObjectCreateAclEntryOperator
   They serve to add permissions to GCS buckets / object for users / service accounts from
   ### Tests
   - [x] My PR adds the following unit tests:
   - `test_bucket_create_acl`
   - `test_bucket_create_acl`
   `` (serving and an integration test)
   ### Commits
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation
   - [x] In case of new functionality, my PR adds documentation that describes how to use
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   ### Code Quality
   - [x] Passes `flake8`

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message