airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside edited a comment on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param and refactor webserver cli function
Date Thu, 15 Nov 2018 07:40:12 GMT
xnuinside edited a comment on issue #4174: [AIRFLOW-571] Airflow CLI: add gunicorn_config param
and refactor webserver cli function
URL: https://github.com/apache/incubator-airflow/pull/4174#issuecomment-438946284
 
 
   @ashb, I check what need to do if we want to use a solution, so, need to modify this -
https://github.com/apache/incubator-airflow/blob/master/airflow/bin/airflow#L31 and for commans
`airflow webserver -p 9090 -op papap` we will get args like - `(Namespace(access_logfile='-',
daemon=False, debug=False, error_logfile='-', func=<function webserver at 0x10c7dd5f0>,
hostname='0.0.0.0', log_file=None, pid=None, port=9090, ssl_cert=None, ssl_key=None, stderr=None,
stdout=None, subcommand='webserver', worker_timeout=120, workerclass='sync', workers=4), ['-op',
'papap'])`
   
   so, for correct work, because all cli wait for Namespace object, not tuple, I need to add:

   `args = parser.parse_known_args()
   args[0].__setattr__('gunicorn_config', args[1])
   args[0].func(args[0])`
   
   this way all works and user don't need to use -gc='' in cli. He can just put all args at
the end of line, and all other code will be without changes 
   
   @ashb is it okay? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message