airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on issue #4164: [AIRFLOW-3318] BigQueryHook check if dataset exists
Date Thu, 15 Nov 2018 07:19:27 GMT
xnuinside commented on issue #4164: [AIRFLOW-3318] BigQueryHook check if dataset exists
URL: https://github.com/apache/incubator-airflow/pull/4164#issuecomment-438942094
 
 
   @ryanyuan,` It only raises AirflowException so that there is no way for me to find out
if the dataset doesn't exist, or something else happen. ` - it put out response of server
with full description and error code, or you don't want to raise error if 404? Why you cannot
do try catch in code there you use this hook? I don't think what it's correct 'silence' errors
from external APIs in hooks, because it's not operators and this method is get_dataset, not
check exist or not - it's return dataset_info. But I'm syre what it's incorrect copy-paste
full code just for except code == 404 - it could be done anythere there you call this code.
When I adding this hook I talk with @kaxil  what maybe make sence add CheckDatasetOperator.
 @kaxil, what do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message