airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
Date Mon, 05 Nov 2018 22:00:32 GMT
odracci commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator
with git-sync
URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r230929468
 
 

 ##########
 File path: airflow/contrib/executors/kubernetes_executor.py
 ##########
 @@ -197,10 +209,15 @@ def __init__(self):
         self._validate()
 
     def _validate(self):
-        if not self.dags_volume_claim and (not self.git_repo or not self.git_branch):
+        # TODO: use XOR for dags_volume_claim and git_dags_folder_mount_point
+        if not self.dags_volume_claim \
+           and (not self.git_repo or not self.git_branch
+                or not self.git_dags_folder_mount_point) \
+           and not self.dags_volume_host:
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message