airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb opened a new pull request #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend
Date Mon, 05 Nov 2018 16:03:29 GMT
ashb opened a new pull request #4133: [AIRFLOW-3270] Allow passwordless-binding for LDAP auth
backend
URL: https://github.com/apache/incubator-airflow/pull/4133
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] https://issues.apache.org/jira/browse/AIRFLOW-3270
   
   ### Description
   
   - [x] Because the bind password came from the config parser it was impossible
   to set it as None, it would come through as `""`, which is not the same
   (to the ldap3 lib) as not providing a password.
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason: no tests -hard to test, but tested by author of Jira ticket.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message