From commits-return-25815-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Mon Oct 22 11:13:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 662CF180675 for ; Mon, 22 Oct 2018 11:13:04 +0200 (CEST) Received: (qmail 16541 invoked by uid 500); 22 Oct 2018 09:13:03 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 16532 invoked by uid 99); 22 Oct 2018 09:13:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 09:13:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 20214C02EC for ; Mon, 22 Oct 2018 09:13:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NrRobnA7M5Iv for ; Mon, 22 Oct 2018 09:13:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 42A585F11F for ; Mon, 22 Oct 2018 09:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 73564E0E1D for ; Mon, 22 Oct 2018 09:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 252C9252A1 for ; Mon, 22 Oct 2018 09:13:00 +0000 (UTC) Date: Mon, 22 Oct 2018 09:13:00 +0000 (UTC) From: "Ash Berlin-Taylor (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-63) Dangling Running Jobs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658765#comment-16658765 ] Ash Berlin-Taylor commented on AIRFLOW-63: ------------------------------------------ Possibly, though if the scheduler process is killed hard (oom, segfault etc) there still may be cases where the job remains running. So I think I'd say "not quite yet" and this is still possibly an issue (at least not fixed by my PR) > Dangling Running Jobs > --------------------- > > Key: AIRFLOW-63 > URL: https://issues.apache.org/jira/browse/AIRFLOW-63 > Project: Apache Airflow > Issue Type: Bug > Components: scheduler > Affects Versions: 1.7.0 > Environment: mac os X with local executor > Reporter: Giacomo Tagliabe > Priority: Minor > > It seems that if the scheduler is killed unexpectedly, the SchedulerJob remains marked as running. Same thing applies to LocalTaskJob: if a job is running when the scheduler dies, the job remains marked as running forever. I'd expect `kill_zombies` to mark the job with an old heartbeat as not running, but it seems it only marks the related task instances. This to me seems like a bug, I also fail to see the piece of code that is supposed to do that, which leads me to think that this is not handled at all. I don't think there is anything really critical about having stale jobs marked as running, but they definitely is confusing to see -- This message was sent by Atlassian JIRA (v7.6.3#76005)