From commits-return-26413-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Mon Oct 29 06:25:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8BA2518077A for ; Mon, 29 Oct 2018 06:25:16 +0100 (CET) Received: (qmail 73402 invoked by uid 500); 29 Oct 2018 05:25:15 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 73393 invoked by uid 99); 29 Oct 2018 05:25:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Oct 2018 05:25:15 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] KimchaC commented on issue #4071: [AIRFLOW-3237] Refactor example DAGs Message-ID: <154079071489.25837.687907265481023374.gitbox@gitbox.apache.org> Date: Mon, 29 Oct 2018 05:25:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit KimchaC commented on issue #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#issuecomment-433792007 One more thing to consider... I noticed the start date is set in the default args. Isn’t that legacy? Since the start_date has no effect on the tasks, shouldn’t it be set on the DAG level? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services