From commits-return-25474-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Oct 16 10:45:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 32168180771 for ; Tue, 16 Oct 2018 10:45:02 +0200 (CEST) Received: (qmail 33937 invoked by uid 500); 16 Oct 2018 08:45:01 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 33916 invoked by uid 99); 16 Oct 2018 08:45:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 08:45:01 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] ashb commented on issue #2519: [AIRFLOW-1508] Add SKIPPED state to task_states Message-ID: <153967950054.18441.4028836165681673696.gitbox@gitbox.apache.org> Date: Tue, 16 Oct 2018 08:45:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on issue #2519: [AIRFLOW-1508] Add SKIPPED state to task_states URL: https://github.com/apache/incubator-airflow/pull/2519#issuecomment-430153414 Can't think of any reason it shouldn't be in the list given everything else is. Switching to `enum` (by pulling in https://pypi.org/project/enum34/ for Pythons older than 3.4) would probably make all of that `State` class simpler and less error prone. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services