From commits-return-25240-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Fri Oct 12 16:25:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E3E51807A1 for ; Fri, 12 Oct 2018 16:24:59 +0200 (CEST) Received: (qmail 40700 invoked by uid 500); 12 Oct 2018 14:24:59 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 40671 invoked by uid 99); 12 Oct 2018 14:24:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2018 14:24:59 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] ashb commented on a change in pull request #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. Message-ID: <153935429853.4221.4597611443053053914.gitbox@gitbox.apache.org> Date: Fri, 12 Oct 2018 14:24:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API. URL: https://github.com/apache/incubator-airflow/pull/3546#discussion_r224801246 ########## File path: airflow/models.py ########## @@ -4878,6 +4880,8 @@ def find(dag_id=None, run_id=None, execution_date=None, qry = qry.filter(DR.dag_id == dag_id) if run_id: qry = qry.filter(DR.run_id == run_id) + if run_id_prefix: Review comment: This one should probably be an `elif` as specifying run_id and run_id_prefix together doesn't make much sense ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services