airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3205) GCS: Support multipart upload
Date Tue, 23 Oct 2018 10:26:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660406#comment-16660406
] 

ASF GitHub Bot commented on AIRFLOW-3205:
-----------------------------------------

chronitis opened a new pull request #4084: [AIRFLOW-3205] Support multipart uploads to GCS
URL: https://github.com/apache/incubator-airflow/pull/4084
 
 
   Cloud Storage supports resumable/multipart uploads for large files,
   which can be used to avoid limitations on the size of a single HTTP
   request, or by adding a retry behaviour, increase the reliability of
   large transfers.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title:
     - https://issues.apache.org/jira/browse/AIRFLOW-3205
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The current `gcs_hook` only supports single-part uploads, which limits the ultimate size
of any single file upload to that which the SSL library supports in a single request, and
may also lead to issues where the network is not wholly reliable and very long-living connections
may be more likely to fail. This adds support for multipart uploads (uploading a single file,
with the actual transport split into multiple HTTP requests), and retries (using the retry
functionality from the `google-api-python-client` library).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   Tests for upload behavior (both multipart and single part) have been added to `tests.contrib.hooks.test_gcs_hook`.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   The added arguments are documented in the hook `upload` method. I haven't explicitly added
all these arguments to classes which use the hook.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GCS: Support multipart upload
> -----------------------------
>
>                 Key: AIRFLOW-3205
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3205
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>            Reporter: Gordon Ball
>            Priority: Minor
>
> GoogleCloudStorageHook currently only provides support for uploading files in a single
HTTP request. This means that loads fail with SSL errors for files larger than 2GiB (presumably
a int32 overflow, might depend on which SSL library is being used). Multipart uploads should
be supported to allow large uploads, and possibly increase reliability for smaller uploads.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message