airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3193) Pin docker requirement version
Date Sat, 20 Oct 2018 18:04:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657938#comment-16657938
] 

ASF GitHub Bot commented on AIRFLOW-3193:
-----------------------------------------

Fokko closed pull request #4042: [AIRFLOW-3193] Pin docker requirement version
URL: https://github.com/apache/incubator-airflow/pull/4042
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/setup.py b/setup.py
index 76f55ab01b..733e22f3b5 100644
--- a/setup.py
+++ b/setup.py
@@ -175,7 +175,7 @@ def write_version(filename=os.path.join(*['airflow',
     'sphinx-rtd-theme>=0.1.6',
     'Sphinx-PyPI-upload>=0.2.1'
 ]
-docker = ['docker>=2.0.0']
+docker = ['docker>=2.0.0,<3.0.0']
 druid = ['pydruid>=0.4.1']
 elasticsearch = [
     'elasticsearch>=5.0.0,<6.0.0',


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pin docker requirement version
> ------------------------------
>
>                 Key: AIRFLOW-3193
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3193
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Guoqiang Ding
>            Assignee: Guoqiang Ding
>            Priority: Major
>
> The method "create_container" in APIClient of docker has been incompatible from version
3.0.0.
>  
> Usage in `_airflow.operators.docker_operator_` as follows.
>  
> {code:java}
> self.container = self.cli.create_container(
>     command=self.get_command(),
>     cpu_shares=cpu_shares,
>     environment=self.environment,
>     host_config=self.cli.create_host_config(
>     binds=self.volumes,
>     network_mode=self.network_mode,
>     shm_size=self.shm_size,
>     dns=self.dns,
>     dns_search=self.dns_search),
>     image=image,
>     mem_limit=self.mem_limit,
>     user=self.user,
>     working_dir=self.working_dir
> )
> {code}
>  
> The arguments such as "cpu_shares" and "mem_limit" has gone off. In other words, after
version 3.0.0, they should be passed into `create_host_config` method.
>  
> {quote}airflow usage code link:
> https://github.com/apache/incubator-airflow/blob/cdbdcae7c0645ac2987360fced43407202716b99/airflow/operators/docker_operator.py#L207
> {quote}
>  
> {quote}version 3.0.0 code link: 
> https://github.com/docker/docker-py/blob/91bc75cc92f578ae9d659ad7e8ed11a0877b70aa/docker/api/container.py#L206
> {quote}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message