airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3173) Add _cmd options for password config options
Date Tue, 09 Oct 2018 14:00:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643476#comment-16643476
] 

ASF GitHub Bot commented on AIRFLOW-3173:
-----------------------------------------

ashb opened a new pull request #4024: [AIRFLOW-3173] Add _cmd options for password config
options
URL: https://github.com/apache/incubator-airflow/pull/4024
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-3173
   
   ### Description
   
   There were a few more "password" config options added over the last few
   months that didn't have _cmd options. Any config option that is a
   password should be able to be provided via a _cmd version.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason: None needed really?
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - Updated docs to mention all config options that are supported by _cmd
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add _cmd options for password config options
> --------------------------------------------
>
>                 Key: AIRFLOW-3173
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3173
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Ash Berlin-Taylor
>            Priority: Major
>             Fix For: 1.10.1
>
>
> Right now we support specifying a command to get a small number of config options ({{sql_alchemy_conn_cmd}}
for instance) but there are some new config options that contain a password that don't have
a {{_cmd }} option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message