airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3137) Make ProxyFix middleware optional
Date Mon, 01 Oct 2018 16:14:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634257#comment-16634257
] 

ASF GitHub Bot commented on AIRFLOW-3137:
-----------------------------------------

jmcarp opened a new pull request #3983: [AIRFLOW-3137] Make ProxyFix middleware optional.
URL: https://github.com/apache/incubator-airflow/pull/3983
 
 
   The ProxyFix middleware should only be used when airflow is running
   behind a trusted proxy. This patch adds a `USE_PROXY_FIX` flag that
   defaults to `False`.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3137
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The ProxyFix middleware should only be used when airflow is running
   behind a trusted proxy. This patch adds a `USE_PROXY_FIX` flag that
   defaults to `False`.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make ProxyFix middleware optional
> ---------------------------------
>
>                 Key: AIRFLOW-3137
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3137
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Josh Carp
>            Assignee: Josh Carp
>            Priority: Trivial
>
> The werkzeug ProxyFix middleware should only be used when the app is run behind a trusted
proxy. We should enable ProxyFix via a configuration flag, like in superset.
> From the werkzeug docs: "Do not use this middleware in non-proxy setups for security
reasons."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message