airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ash Berlin-Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AIRFLOW-3133) Don't `return True` for operators
Date Mon, 01 Oct 2018 10:08:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ash Berlin-Taylor updated AIRFLOW-3133:
---------------------------------------
    Description: 
disable `return True` for SSHOperator since there is already a flag to push to XCOM the stdout,
pushing True to XCOM automatically might be too noisy for XCOM database.

There are other operators that do this as well, and it doesn't provide any value - it just
creates an entry in the XCom table that is redundant - we already know that the task succeeded.

  was:disable `return True` for SSHOperator since there is already a flag to push to XCOM
the stdout, pushing True to XCOM automatically might be too noisy for XCOM database

        Summary: Don't `return True` for operators  (was: [Proposal] Disable `return True`
for SSHOperator)

> Don't `return True` for operators
> ---------------------------------
>
>                 Key: AIRFLOW-3133
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3133
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 1.10.0
>            Reporter: Minh Quan TRAN
>            Priority: Minor
>
> disable `return True` for SSHOperator since there is already a flag to push to XCOM the
stdout, pushing True to XCOM automatically might be too noisy for XCOM database.
> There are other operators that do this as well, and it doesn't provide any value - it
just creates an entry in the XCom table that is redundant - we already know that the task
succeeded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message