airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #4117: [AIRFLOW-3277] Correctly observe DST transitions for cron
Date Tue, 30 Oct 2018 21:13:55 GMT
ashb commented on a change in pull request #4117: [AIRFLOW-3277] Correctly observe DST transitions
for cron
URL: https://github.com/apache/incubator-airflow/pull/4117#discussion_r229488482
 
 

 ##########
 File path: tests/models.py
 ##########
 @@ -580,6 +580,29 @@ def test_cycle(self):
         with self.assertRaises(AirflowDagCycleException):
             dag.test_cycle()
 
+    def test_following_previous_schedule(self):
+        """
+        Make sure DST transitions are properly observed
+        """
+        local_tz = pendulum.timezone('Europe/Zurich')
+        start = datetime(2018, 10, 28, 3, 00, tzinfo=local_tz)
 
 Review comment:
   ```suggestion
           start = datetime.datetime(2018, 10, 28, 3, 00, tzinfo=local_tz)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message