airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo
Date Mon, 29 Oct 2018 14:27:22 GMT
Fokko commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into
tmp config for non-sudo
URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r228947415
 
 

 ##########
 File path: tests/configuration.py
 ##########
 @@ -95,6 +95,14 @@ def test_conf_as_dict_raw(self):
         self.assertEqual(cfg_dict['testsection']['testpercent'], 'with%%percent')
         self.assertEqual(cfg_dict['core']['percent'], 'with%%inside')
 
+    def test_conf_as_dict_exclude_env(self):
+        # test display_sensitive
+        cfg_dict = conf.as_dict(include_env=False, display_sensitive=True)
+
+        # Sinec testsection is only created from env vars, it shouldn't be
 
 Review comment:
   Since*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message