airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Gwildor commented on issue #4085: [AIRFLOW-3112] Fix SFTPHook not validating hosts by default
Date Sat, 27 Oct 2018 22:31:27 GMT
Gwildor commented on issue #4085: [AIRFLOW-3112] Fix SFTPHook not validating hosts by default
URL: https://github.com/apache/incubator-airflow/pull/4085#issuecomment-433660362
 
 
   Ok, I've updated the PR. By default the hook now validates the host keys, which is the
same behaviour as 1.10. Note that this is different behaviour than the SSHHook, but it can
be argued that the SSHHook is in the wrong there. The setting can be overridden using the
deprecated `ignore_hostkey_validation` setting, or the `no_host_key_check` setting. I managed
to get the tests running locally (after struggling a lot to set up an sftp server in my docker
container) and I've added some tests to verify that all the settings now work as intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message