airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #4091: [AIRFLOW-2524] Update SageMaker hook, operator and sensor for training, tuning and transform
Date Sat, 27 Oct 2018 21:58:41 GMT
ashb commented on a change in pull request #4091: [AIRFLOW-2524] Update SageMaker hook, operator
and sensor for training, tuning and transform
URL: https://github.com/apache/incubator-airflow/pull/4091#discussion_r228727702
 
 

 ##########
 File path: airflow/hooks/S3_hook.py
 ##########
 @@ -69,6 +69,23 @@ def get_bucket(self, bucket_name):
         s3 = self.get_resource_type('s3')
         return s3.Bucket(bucket_name)
 
+    def create_bucket(self, bucket_name):
 
 Review comment:
   We don't have a test for this method - can you add one please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message