airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yangaws commented on a change in pull request #4091: [AIRFLOW-2524] Update SageMaker hook, operator and sensor for training, tuning and transform
Date Thu, 25 Oct 2018 18:50:03 GMT
yangaws commented on a change in pull request #4091: [AIRFLOW-2524] Update SageMaker hook,
operator and sensor for training, tuning and transform
URL: https://github.com/apache/incubator-airflow/pull/4091#discussion_r228293416
 
 

 ##########
 File path: tests/contrib/operators/test_sagemaker_tuning_operator.py
 ##########
 @@ -53,8 +53,8 @@
                                 'MetricName': 'test_metric'
                             },
                             'ResourceLimits': {
-                                'MaxNumberOfTrainingJobs': 123,
-                                'MaxParallelTrainingJobs': 123
+                                'MaxNumberOfTrainingJobs': '123',
+                                'MaxParallelTrainingJobs': '123'
 
 Review comment:
   Configurations like this are often computed at runtime and may be stored in XCOM. So if
it's specified using Jinja template in the config, it's always String that I have to convert
to Integer, am I correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message