airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] smentek opened a new pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls
Date Wed, 24 Oct 2018 14:02:24 GMT
smentek opened a new pull request #4090: [AIRFLOW-3250] Fix for Redis Hook for not authorised
connection calls
URL: https://github.com/apache/incubator-airflow/pull/4090
 
 
   Password stay None value and not None (str) in case there is no password set through webadmin
interfaces.
   This is fix for connections for Redis that not expect autorisation from clients. 
   Fixes originally  implemented: https://issues.apache.org/jira/browse/AIRFLOW-999
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/AIRFLOW-3250)
issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-3250
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   his functionality is trivial further description is NOT needed.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   /tests/contrib/hooks/test_redis_hook.py
   /tests/contrib/sensors/test_redis_sensor.py
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   This functionality is trivial and documentation is NOT needed.
   
   ### Code Quality
   
   - [X] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message