airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs
Date Tue, 23 Oct 2018 19:37:15 GMT
BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs
URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227535268
 
 

 ##########
 File path: airflow/example_dags/example_xcom.py
 ##########
 @@ -63,12 +61,21 @@ def puller(**kwargs):
 
 
 push1 = PythonOperator(
-    task_id='push', dag=dag, python_callable=push)
+    task_id='push',
+    dag=dag,
+    python_callable=push,
+)
 
 push2 = PythonOperator(
-    task_id='push_by_returning', dag=dag, python_callable=push_by_returning)
+    task_id='push_by_returning',
+    dag=dag,
+    python_callable=push_by_returning,
+)
 
 pull = PythonOperator(
-    task_id='puller', dag=dag, python_callable=puller)
+    task_id='puller',
+    dag=dag,
+    python_callable=puller,
+)
 
-pull.set_upstream([push1, push2])
+pull << [push1, push2]
 
 Review comment:
   The `<<` and `>>` operators were introduced in Airflow 1.8 and I've never really
heard or seen anybody prefer using the "old" `set_upstream()` and `set_downstream()`. Especially
when chaining multiple tasks your code looks the same as in the GUI and I think it's very
pleasant to read:
   
   ```
   task1 >> task2 >> task3 >> task4
   ```
   
   Since my experience is people use the `>>` and `<<` operators much more, I
figured it'd be useful to show that in the example DAGs, but correct me if wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message