airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ms32035 opened a new pull request #4086: [AIRFLOW-3245] fix list processing in resolve_template_files
Date Tue, 23 Oct 2018 15:53:41 GMT
ms32035 opened a new pull request #4086: [AIRFLOW-3245] fix list processing in resolve_template_files
URL: https://github.com/apache/incubator-airflow/pull/4086
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-3245
   
   ### Description
   
   - [X] resolve_template_files does not process template field value if it is a list
   
   ### Tests
   
   - [ ] Looks like currently the function isn't directly tested. If needed, please advise
where should I add a test case
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [X] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message