airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] evizitei opened a new pull request #4082: [AIRFLOW-2865] Call success_callback before updating task state
Date Mon, 22 Oct 2018 21:28:55 GMT
evizitei opened a new pull request #4082: [AIRFLOW-2865] Call success_callback before updating
task state
URL: https://github.com/apache/incubator-airflow/pull/4082
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-2865/)
issues and references them in the PR title.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   In cases where the success callback takes variable
   time, it's possible for it to interrupted by the heartbeat process.
   This is because the heartbeat process looks for tasks that are no
   longer in the "running" state but are still executing and reaps them.
   
   This commit reverses the order of callback invocation and state
   updating so that the "SUCCESS" state for the task isn't committed
   to the database until after the success callback has finished.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   TaskInstanceTest.test_success_callbak_no_race_condition
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message