airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dossett opened a new pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
Date Wed, 17 Oct 2018 16:58:53 GMT
dossett opened a new pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on
ERROR
URL: https://github.com/apache/incubator-airflow/pull/4064
 
 
   Sometimes a dataproc cluster creation results in a
   cluster in a state of ERROR, which makes it unsuable.
   Subsequent Airflow retries will fail because a cluster
   already exists.  This change adds the option to delete
   an ERROR cluster on creation so that subsequent attempts
   might succeed.  There are also some other small cleanups.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3149/)
issues and references them in the PR title.
   
   ### Description
   
   - [X] See commit message above
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:  
   
   My change does not include tests, I did not see any integration tests in the code base
that this could fit into.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
   I am not sure how to test this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message