airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] brylie commented on a change in pull request #4055: [AIRFLOW-3206] neutral and clear GPL dependency notice
Date Tue, 16 Oct 2018 09:28:48 GMT
brylie commented on a change in pull request #4055: [AIRFLOW-3206] neutral and clear GPL dependency
notice
URL: https://github.com/apache/incubator-airflow/pull/4055#discussion_r225463890
 
 

 ##########
 File path: setup.py
 ##########
 @@ -46,11 +46,13 @@ def verify_gpl_dependency():
         os.environ["SLUGIFY_USES_TEXT_UNIDECODE"] = "yes"
 
     if not os.getenv("AIRFLOW_GPL_UNIDECODE") and not os.getenv("SLUGIFY_USES_TEXT_UNIDECODE")
== "yes":
-        raise RuntimeError("By default one of Airflow's dependencies installs a GPL "
-                           "dependency (unidecode). To avoid this dependency set "
-                           "SLUGIFY_USES_TEXT_UNIDECODE=yes in your environment when you
"
-                           "install or upgrade Airflow. To force installing the GPL "
-                           "version set AIRFLOW_GPL_UNIDECODE")
+        raise RuntimeError(
+            "By default, one of Airflow's dependencies (unidecode) is GPL licensed .\n"
+            "In order to proceed with installation, "
+            "you will need to set one of the following environment variables:\n"
+            "To disallow the dependency, export SLUGIFY_USES_TEXT_UNIDECODE=yes.\n"
 
 Review comment:
   Cool. By the way, what is the issue with using a GPL'd dependency? To my understanding,
there is no hard-linking with this module that would require downstream projects to be open
source.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message