airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] r39132 commented on a change in pull request #4034: Update UPDATING.md
Date Sun, 14 Oct 2018 19:11:15 GMT
r39132 commented on a change in pull request #4034: Update UPDATING.md
URL: https://github.com/apache/incubator-airflow/pull/4034#discussion_r225004844
 
 

 ##########
 File path: UPDATING.md
 ##########
 @@ -180,6 +180,11 @@ elasticsearch_end_of_log_mark = end_of_log
 ```
 
 The previous setting of `log_task_reader` is not needed in many cases now when using the
default logging config with remote storages. (Previously it needed to be set to `s3.task`
or similar. This is not needed with the default config anymore)
+basically 
+```
+[core]
+task_log_reader = task
 
 Review comment:
   This section is not as clear as it can be. The word `basically` does not add any discernibility.
Are you saying that the section you added is the new state or the old state? Please add more
text to convey what the old and new states are with illustrative config section examples.
Like 
   ```
   before upgrade
      config section
   after upgrade
      config section
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message