airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG opened a new pull request #4049: [AIRFLOW-3203] Fix DockerOperator & its test
Date Sat, 13 Oct 2018 15:42:01 GMT
XD-DENG opened a new pull request #4049: [AIRFLOW-3203] Fix DockerOperator & its test
URL: https://github.com/apache/incubator-airflow/pull/4049
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3203
   
   ### Description
   
   - For argument `image`, no need to explicitly add "latest" if tag is omitted.
     "latest" will be used by default if no tag provided. This is handled by `docker` package
itself.
   
   - Intermediate variable `cpu_shares` is not needed.
   
   - Fix wrong usage of `cpu_shares` and `cpu_shares`.
     Based on https://docker-py.readthedocs.io/en/stable/api.html#docker.api.container.ContainerApiMixin.create_host_config,
     They should be an arguments of self.cli.create_host_config() rather than APIClient.create_container().
   
   - Change name of the corresponding test script, to ensure it can be discovered.
   
   - Fix the test itself.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message