airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #4044: [AIRFLOW-3197] EMRHook is missing new parameters of the AWS API
Date Sat, 13 Oct 2018 06:25:42 GMT
Fokko commented on a change in pull request #4044: [AIRFLOW-3197] EMRHook is missing new parameters
of the AWS API
URL: https://github.com/apache/incubator-airflow/pull/4044#discussion_r224951208
 
 

 ##########
 File path: UPDATING.md
 ##########
 @@ -72,6 +72,16 @@ then you need to change it like this
     def is_active(self):
       return self.active
 
+### EMRHook now passes all of connection's extra to CreateJobFlow API
+
+EMRHook.create_job_flow has been changed to pass all keys to the create_job_flow API, rather
than
+just specific known keys for greater flexibility.
 
 Review comment:
   Not only greater flexibility, but less error prone :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message