airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3546: AIRFLOW-2664: Support filtering dag runs by id prefix in API.
Date Fri, 12 Oct 2018 14:24:58 GMT
ashb commented on a change in pull request #3546: AIRFLOW-2664: Support filtering dag runs
by id prefix in API.
URL: https://github.com/apache/incubator-airflow/pull/3546#discussion_r224801246
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -4878,6 +4880,8 @@ def find(dag_id=None, run_id=None, execution_date=None,
             qry = qry.filter(DR.dag_id == dag_id)
         if run_id:
             qry = qry.filter(DR.run_id == run_id)
+        if run_id_prefix:
 
 Review comment:
   This one should probably be an `elif` as specifying run_id and run_id_prefix together doesn't
make much sense

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message