airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #3955: [AIRFLOW-3121] Define closed property on StreamLogWriter
Date Fri, 12 Oct 2018 11:42:39 GMT
Fokko commented on a change in pull request #3955: [AIRFLOW-3121] Define closed property on
StreamLogWriter
URL: https://github.com/apache/incubator-airflow/pull/3955#discussion_r224756638
 
 

 ##########
 File path: airflow/utils/log/logging_mixin.py
 ##########
 @@ -83,6 +84,16 @@ def __init__(self, logger, level):
         self.level = level
         self._buffer = str()
 
+    @property
+    def closed(self):
+        """
+        Returns False to indicate that the stream is not closed (as it will be
+        open for the duration of Airflow's lifecycle).
+
+        For compatibility.
 
 Review comment:
   @jinnovation 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message