airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] phani8996 commented on a change in pull request #3992: [AIRFLOW-620] Feature to tail custom number of logs instead of rendering whole log
Date Tue, 09 Oct 2018 14:54:32 GMT
phani8996 commented on a change in pull request #3992: [AIRFLOW-620] Feature to tail custom
number of logs instead of rendering whole log
URL: https://github.com/apache/incubator-airflow/pull/3992#discussion_r223736747
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -836,6 +839,21 @@ def log(self, session=None):
         dttm = pendulum.parse(execution_date)
         form = DateTimeForm(data={'execution_date': dttm})
         dag = dagbag.get_dag(dag_id)
+        metadata = {}
+        tailing_required = False
+        tail_lines_list = [100, 200, 500, 1000]
 
 Review comment:
   I am using 3 values from config for this feature. A flag(`tail_logs`), default value(`num_lines`)
and comma separated string(`tail_lines_list`). Above hard coded value is added to avoid app
crashes in the cases where flag is true and `tail_lines_list` variable is not defined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message