airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vardancse commented on a change in pull request #3994: [AIRFLOW-3136] Add retry_number to TaskInstance Key property to avoid race condition
Date Mon, 08 Oct 2018 06:35:56 GMT
vardancse commented on a change in pull request #3994: [AIRFLOW-3136] Add retry_number to TaskInstance
Key property to avoid race condition
URL: https://github.com/apache/incubator-airflow/pull/3994#discussion_r223258140
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -1230,7 +1230,7 @@ def key(self):
         """
         Returns a tuple that identifies the task instance uniquely
         """
-        return self.dag_id, self.task_id, self.execution_date
+        return self.dag_id, self.task_id, self.execution_date, self.try_number
 
 Review comment:
   @ashb Looking forward to your feedback!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message