airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on issue #3985: [AIRFLOW-3138] Use current data type for migrations
Date Tue, 02 Oct 2018 08:54:21 GMT
ashb commented on issue #3985: [AIRFLOW-3138] Use current data type for migrations
URL: https://github.com/apache/incubator-airflow/pull/3985#issuecomment-426199116
 
 
   @bolkedebruin This looks okay to me - do you have time for a quick check too.
   
   I think this is okay as our UtcDateTime type is the same column type under the hood. But
thinking a bit more about it does doing this set the timezones incorrectly on the row. Hmmmmm.
   
   (Turns out there's no way to remove a review approval in github)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message