From commits-return-20222-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Sun Sep 2 20:02:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 059EC1807A3 for ; Sun, 2 Sep 2018 20:02:09 +0200 (CEST) Received: (qmail 14089 invoked by uid 500); 2 Sep 2018 18:02:09 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 13934 invoked by uid 99); 2 Sep 2018 18:02:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2018 18:02:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B82571A1CF4 for ; Sun, 2 Sep 2018 18:02:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 68IzeulyMcwy for ; Sun, 2 Sep 2018 18:02:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B651C5F5BA for ; Sun, 2 Sep 2018 18:02:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 338B9E261D for ; Sun, 2 Sep 2018 18:02:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6D4A626B9D for ; Sun, 2 Sep 2018 18:02:03 +0000 (UTC) Date: Sun, 2 Sep 2018 18:02:03 +0000 (UTC) From: "Apache Spark (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1021) Double logging required for new users with LDAP MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601434#comment-16601434 ] Apache Spark commented on AIRFLOW-1021: --------------------------------------- User 'wolfier' has created a pull request for this issue: https://github.com/apache/incubator-airflow/pull/2778 > Double logging required for new users with LDAP > ----------------------------------------------- > > Key: AIRFLOW-1021 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1021 > Project: Apache Airflow > Issue Type: Bug > Components: contrib > Affects Versions: Airflow 1.8 > Reporter: Marcelo G. Almiron > Assignee: Alan Ma > Priority: Major > > Every user needs to login twice to access Airflow for the first time with LDAP. > In the first trial the user is not persistent, so there is no `id` associated, which leads to `None` value returned by `load_user(userid)`, since `userid` is none `None`. > A quick fix is to add the new user to the session and commit before merging. That is, in module `airflow/contrib/auth/backends/ldap_auth.py`, we can change > ``` > if not user: > user = models.User( > username=username, > is_superuser=False) > session.merge(user) > session.commit() > flask_login.login_user(LdapUser(user)) > ``` > by > ``` > if not user: > user = models.User( > username=username, > is_superuser=False) > session.add(user) > > session.commit() > session.merge(user) > flask_login.login_user(LdapUser(user)) > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005)