From commits-return-21477-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Sep 11 15:51:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1887018076D for ; Tue, 11 Sep 2018 15:51:04 +0200 (CEST) Received: (qmail 14472 invoked by uid 500); 11 Sep 2018 13:51:03 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 14455 invoked by uid 99); 11 Sep 2018 13:51:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2018 13:51:03 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] xnuinside commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load Message-ID: <153667386318.21870.1693304853874304448.gitbox@gitbox.apache.org> Date: Tue, 11 Sep 2018 13:51:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit xnuinside commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r216676844 ########## File path: airflow/contrib/hooks/bigquery_hook.py ########## @@ -851,8 +851,9 @@ def run_copy(self, def run_load(self, destination_project_dataset_table, Review comment: @fokko, Exuse me) I can’t catch how it breaks if there are no changes to old args and no logic changes. Just for understanding, seems I miss something. About contributing.md - okay. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services