airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3123) DAG context manager fails in nested cases
Date Wed, 26 Sep 2018 21:39:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629440#comment-16629440
] 

ASF GitHub Bot commented on AIRFLOW-3123:
-----------------------------------------

newtonle opened a new pull request #3956: [AIRFLOW-3123] Use a stack for DAG context management
URL: https://github.com/apache/incubator-airflow/pull/3956
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3123
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Implemented a stack to manage the DAG context. Entering a DAG context pushes the past context
on the stack. Exiting pops the stack to reset the context. This allows arbitrary nesting of
contexts, particularly if the same DAG object is used in the nesting.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   Modified `test_dag_as_context_manager` in `models.py` to capture this condition.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DAG context manager fails in nested cases
> -----------------------------------------
>
>                 Key: AIRFLOW-3123
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3123
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: DAG
>            Reporter: Newton Le
>            Assignee: Newton Le
>            Priority: Major
>
> DAG context manager fails under some cases with nested contexts:
> {code:python}
> with DAG( ... ) as dag:
>   op1 = Operator()
>   with dag:
>     op2 = Operator()
>   op3 = Operator
> {code}
> op3 will not continue to be assigned the original DAG after exiting the nested context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message