airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3077) Mongo Hook Raise Error and Stop Migration Due to Bad Encoding from PyMongo
Date Mon, 17 Sep 2018 13:55:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617554#comment-16617554
] 

ASF GitHub Bot commented on AIRFLOW-3077:
-----------------------------------------

berniechiu opened a new pull request #3912: [AIRFLOW-3077] Default Not to Raise Error When
PyMongo Contruct JSON Data
URL: https://github.com/apache/incubator-airflow/pull/3912
 
 
   This PR resolved [Encoding Problem](https://stackoverflow.com/questions/36314776/pymongo-error-bson-errors-invalidbson-utf8-codec-cant-decode-byte-0xa1-in-p)
when we try to migrate data from Mongo Hook.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Mongo Hook Raise Error and Stop Migration Due to Bad Encoding from PyMongo
> --------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3077
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3077
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: database, hooks
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Bernie Chiu
>            Assignee: Bernie Chiu
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Due to the fact that a single encoding problem should not stop the dataflow, provide
the default with `ignore` option is best for default since PyMongo will still try to do its
best to reconstruct the JSON data.
> [https://stackoverflow.com/questions/36314776/pymongo-error-bson-errors-invalidbson-utf8-codec-cant-decode-byte-0xa1-in-p]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message