airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3059) PostgresToGCS log the number of rows
Date Sun, 16 Sep 2018 08:59:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616637#comment-16616637
] 

ASF GitHub Bot commented on AIRFLOW-3059:
-----------------------------------------

Fokko opened a new pull request #3905: [AIRFLOW-3059] Log how many rows are read from Postgres
URL: https://github.com/apache/incubator-airflow/pull/3905
 
 
   To know how many data is being read from Postgres, it is nice to log
   this to the Airflow log.
   
   Previously when there was no data, it would still create a single file.
   This is not something that we want, and therefore we've changed this
   behaviour.
   
   Refactored the tests to make use of Postgres itself since we have it
   running. This makes the tests more realistic, instead of mocking
   everything.
   
   Reopen version of #3898 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-3059\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3059
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-3059\], code changes always need a Jira issue.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> PostgresToGCS log the number of rows
> ------------------------------------
>
>                 Key: AIRFLOW-3059
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3059
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Fokko Driesprong
>            Priority: Major
>
> Log how many rows are being read from Postgres



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message