airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3049) Add update, replace, delete commands for Mongo hook
Date Wed, 12 Sep 2018 17:14:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612480#comment-16612480
] 

ASF GitHub Bot commented on AIRFLOW-3049:
-----------------------------------------

dlebech opened a new pull request #3890: [AIRFLOW-3049] Add extra operations for Mongo hook
URL: https://github.com/apache/incubator-airflow/pull/3890
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3049
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR adds six extra operations to the Mongo hook: `update`, `replace` and `delete` as
well as a `*_many` version for each of those.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   * `test_update_one`
   * `test_update_one_with_upsert`
   * `test_update_many`
   * `test_update_many_with_upsert`
   * `test_replace_one`
   * `test_replace_one_with_filter`
   * `test_replace_one_with_upsert`
   * `test_replace_many`
   * `test_replace_many_with_upsert`
   * `test_delete_one`
   * `test_delete_many`
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add update, replace, delete commands for Mongo hook
> ---------------------------------------------------
>
>                 Key: AIRFLOW-3049
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3049
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, hooks
>    Affects Versions: 1.10.0
>            Reporter: David Volquartz Lebech
>            Assignee: David Volquartz Lebech
>            Priority: Minor
>
> For the MongoDB hook (in {{contrib.hooks.mongo_hook}}), there are no update, replace
and delete functions. They would be nice to have.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message