airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3029) New Operator - SqlOperator
Date Wed, 12 Sep 2018 20:23:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612686#comment-16612686
] 

ASF GitHub Bot commented on AIRFLOW-3029:
-----------------------------------------

jbacon opened a new pull request #3891: [AIRFLOW-3029] New Operator - SqlOperator
URL: https://github.com/apache/incubator-airflow/pull/3891
 
 
   Introduces a new `SqlOperator` that executes sql code in a database. Surprisingly this
operator doesn't already exist. It is not always necessary to implement individual operators
for each SQL database (`PostgresOperator`, `MySqlOperator`,etc..), which this operator shows.
Similar to `SqlSensor`.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3029)
issues and references them in the PR title. 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This abstract operator can be instantiated directly,
   and does not need to be derived into subclasses for each DbApiHook subclass.
   It will automatically uses the correct DbApiHook subclass implementation,
   made possible by reflecting upon the specified Connection's `conn_type`.
   
   Date:      Fri Sep 7 16:06:56 2018 -0700
   new file:   airflow/contrib/operators/sql_operator.py
   new file:   tests/contrib/operators/test_sql_operator.py
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   `/tests/contrib/operators/test_sql_operator.py`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> New Operator - SqlOperator
> --------------------------
>
>                 Key: AIRFLOW-3029
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3029
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: operators
>            Reporter: Josh Bacon
>            Assignee: Josh Bacon
>            Priority: Major
>              Labels: operator
>
> Proposal to add a new operator "SqlOperator" which actually doesn't already exist yet.
> I will be submitting a Pull Request soon. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message