airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3007) Scheduler docs use deprecated use of `schedule_interval`
Date Tue, 04 Sep 2018 23:58:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603739#comment-16603739
] 

ASF GitHub Bot commented on AIRFLOW-3007:
-----------------------------------------

r39132 closed pull request #3847: [AIRFLOW-3007] Update backfill example in Scheduler docs
URL: https://github.com/apache/incubator-airflow/pull/3847
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/scheduler.rst b/docs/scheduler.rst
index 3e895898fc..df85d28785 100644
--- a/docs/scheduler.rst
+++ b/docs/scheduler.rst
@@ -109,11 +109,15 @@ interval series.
         'email_on_failure': False,
         'email_on_retry': False,
         'retries': 1,
-        'retry_delay': timedelta(minutes=5),
-        'schedule_interval': '@hourly',
+        'retry_delay': timedelta(minutes=5)
     }
 
-    dag = DAG('tutorial', catchup=False, default_args=default_args)
+    dag = DAG(
+        'tutorial',
+        default_args=default_args,
+        description='A simple tutorial DAG',
+        schedule_interval='@hourly',
+        catchup=False)
 
 In the example above, if the DAG is picked up by the scheduler daemon on 2016-01-02 at 6
AM, (or from the
 command line), a single DAG Run will be created, with an ``execution_date`` of 2016-01-01,
and the next


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Scheduler docs use deprecated use of `schedule_interval` 
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-3007
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3007
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: docs, Documentation
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: screenshot-1.png
>
>
> The scheduler docs at https://airflow.apache.org/scheduler.html#backfill-and-catchup
use deprecated way of passing {{schedule_interval}} . {{schedule_interval}}  should be pass
to DAG as a separate parameter and not as a default arg.
>  !screenshot-1.png! 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message