airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] akosel commented on a change in pull request #2372: [AIRFLOW-393] Add callback for FTP downloads
Date Fri, 28 Sep 2018 16:41:21 GMT
akosel commented on a change in pull request #2372: [AIRFLOW-393] Add callback for FTP downloads
URL: https://github.com/apache/incubator-airflow/pull/2372#discussion_r221313853
 
 

 ##########
 File path: airflow/contrib/hooks/ftp_hook.py
 ##########
 @@ -161,6 +165,9 @@ def retrieve_file(self, remote_full_path, local_full_path_or_buffer):
         :param local_full_path_or_buffer: full path to the local file or a
             file-like buffer
         :type local_full_path_or_buffer: str or file-like buffer
+        :param callback: callback that can be used for tracking download
+            progress, among other things
+        :type callback: callable
 
 Review comment:
   Good idea! I also added an example section to the docstring. If that seems excessive, I
can remove it. Emphasis on the need to handle writing to the file inside of the custom callback
if it is used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message