airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #2372: [AIRFLOW-393] Add callback for FTP downloads
Date Fri, 28 Sep 2018 12:25:56 GMT
ashb commented on a change in pull request #2372: [AIRFLOW-393] Add callback for FTP downloads
URL: https://github.com/apache/incubator-airflow/pull/2372#discussion_r221235162
 
 

 ##########
 File path: airflow/contrib/hooks/ftp_hook.py
 ##########
 @@ -161,6 +165,9 @@ def retrieve_file(self, remote_full_path, local_full_path_or_buffer):
         :param local_full_path_or_buffer: full path to the local file or a
             file-like buffer
         :type local_full_path_or_buffer: str or file-like buffer
+        :param callback: callback that can be used for tracking download
+            progress, among other things
+        :type callback: callable
 
 Review comment:
   Can we have some docs on what the callback is called with (what args), when it is called,
what doesn't happen normally if you use a callback (i.e. I think it won't write any files.)
   
   Also possibly as implemeneted now it would be better to make callback at local_full_path_or_bucket
to be mutually exclusive - if a callback is passed the local_* argument is ignored.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message