airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook
Date Tue, 25 Sep 2018 18:33:50 GMT
ashb commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit
SSH hook
URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r220305589
 
 

 ##########
 File path: airflow/contrib/hooks/sftp_hook.py
 ##########
 @@ -40,42 +43,47 @@ class SFTPHook(BaseHook):
     """
 
     def __init__(self, ftp_conn_id='sftp_default'):
-        self.ftp_conn_id = ftp_conn_id
-        self.conn = None
+        super(SFTPHook, self).__init__(ftp_conn_id)
 
 Review comment:
   I would add `*args, **kwargs` to the func sig and super call 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message