airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG commented on a change in pull request #3939: [AIRFLOW-3104] Add .airflowignore info into doc
Date Sun, 23 Sep 2018 23:03:16 GMT
XD-DENG commented on a change in pull request #3939: [AIRFLOW-3104] Add .airflowignore info
into doc
URL: https://github.com/apache/incubator-airflow/pull/3939#discussion_r219714882
 
 

 ##########
 File path: airflow/models.py
 ##########
 @@ -522,10 +522,12 @@ def collect_dags(
         Given a file path or a folder, this method looks for python modules,
         imports them and adds them to the dagbag collection.
 
-        Note that if a .airflowignore file is found while processing,
-        the directory, it will behaves much like a .gitignore does,
+        Note that if a ``.airflowignore`` file is found while processing
 
 Review comment:
   This .airflowignore file should be in DAG_FOLDER. I mentioned it in my change in “docs/concepts”.

   
   It’s a great idea to have a placeholder .airflowignore. But it’s a bit tricky to do
this since users normally need to create “dags” folder by themselves after initdb.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message