airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #3894: [AIRFLOW-3055] add get_dataset and get_datasets_list to bigquery_hook
Date Sat, 22 Sep 2018 18:10:57 GMT
kaxil commented on a change in pull request #3894: [AIRFLOW-3055] add get_dataset and get_datasets_list
to bigquery_hook
URL: https://github.com/apache/incubator-airflow/pull/3894#discussion_r219678551
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1375,6 +1375,74 @@ def delete_dataset(self, project_id, dataset_id):
                 'BigQuery job failed. Error was: {}'.format(err.content)
             )
 
+    def get_dataset(self, dataset_id="", project_id=""):
+        """
+        Method returned dataset_resource if dataset exist
 
 Review comment:
   nit:  "returns dataset_resource"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message