airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dimberman commented on a change in pull request #3683: [AIRFLOW-2770] kubernetes: add support for dag folder in the docker i…
Date Fri, 21 Sep 2018 22:42:55 GMT
dimberman commented on a change in pull request #3683: [AIRFLOW-2770] kubernetes: add support
for dag folder in the docker i…
URL: https://github.com/apache/incubator-airflow/pull/3683#discussion_r219643849
 
 

 ##########
 File path: airflow/contrib/executors/kubernetes_executor.py
 ##########
 @@ -128,6 +128,10 @@ def __init__(self):
             self.kubernetes_section, 'worker_service_account_name')
         self.image_pull_secrets = conf.get(self.kubernetes_section, 'image_pull_secrets')
 
+        # NOTE: user can build the dags into the docker image directly,
+        # this will set to True if so
+        self.dags_in_docker = conf.get(self.kubernetes_section, 'dags_in_docker')
 
 Review comment:
   Can you change this name to "dags_in_image"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message