airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yrqls21 commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop from scheduler loop
Date Fri, 21 Sep 2018 19:19:07 GMT
yrqls21 commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop
from scheduler loop
URL: https://github.com/apache/incubator-airflow/pull/3873#discussion_r219601977
 
 

 ##########
 File path: airflow/config_templates/airflow_local_settings.py
 ##########
 @@ -172,6 +196,20 @@
 
 REMOTE_LOGGING = conf.get('core', 'remote_logging')
 
+if os.environ.get('CONFIG_PROCESSOR_MANAGER_LOGGER') == 'True':
 
 Review comment:
   @XD-DENG you are perfectly correctly. The purpose is to avoid `RotatingFileHandler` to
be initialized in multiple processes, which would cause exceptions. I thought I had some comments
around it but obviously I'm wrong :(
   
   @ashb This is more like a internal flag controlling the behavior of different processes,
similar idea as this line https://github.com/apache/incubator-airflow/blob/master/airflow/bin/cli.py#L868,
I'll definitely add comments here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message