airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop from scheduler loop
Date Fri, 21 Sep 2018 18:21:11 GMT
ashb commented on a change in pull request #3873: [Airflow-2760] Decouple DAG parsing loop
from scheduler loop
URL: https://github.com/apache/incubator-airflow/pull/3873#discussion_r219587044
 
 

 ##########
 File path: airflow/config_templates/airflow_local_settings.py
 ##########
 @@ -172,6 +196,20 @@
 
 REMOTE_LOGGING = conf.get('core', 'remote_logging')
 
+if os.environ.get('CONFIG_PROCESSOR_MANAGER_LOGGER') == 'True':
 
 Review comment:
   This feels like it should be a config option somewhere in the config, and then the normal
`AIRFLOW__${SECT}__${OPT}` environment variables could be used.
   
   Also there is zero documentation or metion anywher eelse what this block is doing.  Adding
to the default config (with comments explaining it's use) gives us two birds with one stone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message