airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dlebech commented on issue #3890: [AIRFLOW-3049] Add extra operations for Mongo hook
Date Mon, 17 Sep 2018 15:02:51 GMT
dlebech commented on issue #3890: [AIRFLOW-3049] Add extra operations for Mongo hook
URL: https://github.com/apache/incubator-airflow/pull/3890#issuecomment-422052369
 
 
   @Fokko Thanks!
   
   Regarding mocking vs real instance, I'm not sure I'm in the best position to answer that
since I basically just built this PR upon the pre-existing setup, so I cannot say why `mongomock`
was originally chosen.
   
   But it looks like a pretty good library for this kind of thing, and since Travis is already
taking a very long time to run, I assume mocking speeds thing up a bit in this case. I don't
know how much that matters, but at least from my perspective, it feels like mocking is an
ok thing to do 🙂 
   
   Perhaps the original author @andscoop has a better opinion than mine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message